Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new histogram metric s3nd_upload_parts to track the number of parts per file in S3 multipart uploads. The metric is configured as a native histogram with specific bucket settings and includes labels for code and reason.
- Adds a new Prometheus histogram metric to monitor upload part counts
- Configures the metric with native histogram settings including bucket factor and thresholds
- Updates the metrics test to include the new metric in validation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| upload/handler.go | Adds uploadParts histogram metric definition and observation call |
| test/metrics_test.go | Includes new metric name in test validation list |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.